Fix strict application to function-after with use_enum_values
#9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review @dmontagu |
Deploying pydantic-docs with
|
| Latest commit: |
9f375c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53f6dc51.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-enum-strict-schema.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #9279 will not alter performanceComparing Summary
|
dmontagu
reviewed
Apr 18, 2024
| @@ -195,6 +195,12 @@ def apply_known_metadata(annotation: Any, schema: CoreSchema) -> CoreSchema | No | |||
| raise ValueError(f'Unknown constraint {constraint}') | |||
| allowed_schemas = CONSTRAINTS_TO_ALLOWED_SCHEMAS[constraint] | |||
|
|
|||
| # if it becomes necessary to handle more than one constraint | |||
| # in this recursive case with function-after or function-wrap, we should refactor | |||
| if schema_type in ['function-before', 'function-wrap', 'function-after'] and constraint == 'strict': | |||
There was a problem hiding this comment.
Better to use a set here, and possibly store it out of line. I’d be okay with just making it a set though
|
Yep. Added said issue to the 2.8 milestone! |
|
Here's that issue: #9281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9257
Selected Reviewer: @samuelcolvin