New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TODO regarding pickling to markdown #9288
Conversation
CodSpeed Performance ReportMerging #9288 will not alter performanceComparing Summary
|
please review |
We'll have to get the test working to verify that! |
Sorry about that, I re-enabled the test. At least locally it seems to work as expected. Let's see what CI thinks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Oh hmm, looks like this is still failing tests:
|
Yeah, looks like the failure just happens in the doctests. I moved the comment to a markdown such that it doesn't show up in the public docs which might confuse some users |
Ah nice. Looks good! |
Change Summary
As far as I can tell pickling is supported by pydantic, so I think this TODO in the docs can be removed.
Checklist
Selected Reviewer: @adriangb