Fix bug where - was passing as a valid date.
#51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 99.10% 98.78% -0.32%
==========================================
Files 6 6
Lines 890 903 +13
==========================================
+ Hits 882 892 +10
- Misses 8 11 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
davidhewitt
reviewed
Nov 6, 2023
Comment on lines
+3
to
+13
| // Parse bytes as an int with JSON semantics. | ||
| pub fn parse_int_with_json_semantics(bytes: &[u8]) -> Option<i64> { | ||
| const JSON: u128 = lexical_format::JSON; | ||
| let int_options = ParseIntegerOptions::new(); | ||
| let int_result: Result<i64, lexical_core::Error> = parse_with_options::<i64, JSON>(bytes, &int_options); | ||
|
|
||
| match int_result { | ||
| Ok(parsed_int) => Some(parsed_int), | ||
| Err(_) => None, | ||
| } | ||
| } |
There was a problem hiding this comment.
By introducing a new function here it looks like int_parse_bytes and int_parse_str will continue to accept + and - as valid integers. Might it be better to instead fix those functions to reject those inputs?
There was a problem hiding this comment.
Pushed #51 as an alternative.
|
replaced by #52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pydantic/pydantic#7872
-is no longer parsing as a valid date.