Updates for file src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po in fr #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![transifex-integration[bot]](https://avatars.githubusercontent.com/in/18568?s=60&v=4){kind=small}
100% translated source file: 'sphinx.po' on 'fr'.
drammock
approved these changes
May 2, 2024
97% of minimum 100% translated source file: 'sphinx.po' on 'fr'.
Carreau
reviewed
May 14, 2024
| @@ -156,6 +156,10 @@ msgstr "" | |||
| "theme.readthedocs.io/en/stable/index.html\">Thème PyData Sphinx</a> " | |||
| "%(theme_version)s." | |||
|
|
|||
| #: src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/announcement.html:1 | |||
| msgid "Announcement" | |||
| msgstr "" | |||
There was a problem hiding this comment.
I must confess I don't fully understand what is the right way to translate this theme but this string was untranslated on Transifex and I just proceeded. So I guess the sphinx.po file should be updated sooner or later.
100% translated source file: 'sphinx.po' on 'fr'.
drammock
reviewed
May 14, 2024
Comment on lines
+19
to
+23
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "Generated-By: Babel 2.13.0\n" | ||
| "Language: fr\n" | ||
| "Plural-Forms: nplurals=3; plural=(n == 0 || n == 1) ? 0 : n != 0 && n % 1000000 == 0 ? 1 : 2;\n" |
There was a problem hiding this comment.
I wish I knew why transifex keeps introducing trivial changes like utf -> UTF or changing the order of these header/metadata lines. It makes these PRs much harder to assess.
There was a problem hiding this comment.
We can try to introduce a precomit-ci hook that normalise all those...
There was a problem hiding this comment.
import polib
po = polib.pofile("sphinx.po")
po.metadata = {k: v for k, v in sorted(po.metadata.items())}
po.save("sphinx.po")Should at least sort headers...
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this pull request
May 16, 2024
See thread in pydata#1801 – automatic update from transifex-integration bot have random changes in metadata content and order that are just noise. With this the bot should do the PR and pre-commit-ci should hopefully push a second commit that remove all churn in metadata.
Coverage report
This PR does not seem to contain any modification to coverable code. |
Carreau
added a commit
that referenced
this pull request
May 22, 2024
See thread in #1801 – automatic update from transifex-integration bot have random changes in metadata content and order that are just noise. With this the bot should do the PR and pre-commit-ci should hopefully push a second commit that remove all churn in metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following localization files have been updated: