purge codecov #1809
Merged
purge codecov #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
added
the
kind: maintenance
drammock
commented
May 10, 2024
| @@ -131,7 +123,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| needs: run-pytest | |||
| # run both on previous step success and failure | |||
| if: "!cancelled()" | |||
| if: ${{ !cancelled() }} | |||
There was a problem hiding this comment.
unrelated change: My IDE was highlighting this as errorful (I think maybe because of the double quotes?). This is how they do it in the docs
There was a problem hiding this comment.
Thanks! I think this is to ensure expansion/var replacement is more robust by adding the {{ }}
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
CI is happy so will go ahead and merge 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when reviewing #1807 that codecov CI is still running (and failing). It should have been removed in #1756 (oops).