Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix django commands hack. now django doesn't require specific overrid… #3153

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

davidleon
Copy link

…e commands hook. django staticfiles runserver should properly run. and test against django 2.0

…e commands hook. django staticfiles runserver should properly run. and test against django 2.0
@ghost
Copy link

ghost commented Dec 23, 2017

This doesn't appear to work on Python 2.7, which unfortunately is still the majority of our user base.

… app should load correctly. original fix doesn't load admin app correctly
@davidleon
Copy link
Author

new to python maybe someone can help to alter the code to be python2 and 3 compatible? not sure why it's not working in python 2.7

@ghost
Copy link

ghost commented Dec 25, 2017

Almost there. Rerun this command and iterate until it passes. Then I'll help you clean this up.

[in PyInstaller directory]
pip install -e .
pytest tests/functional/test_hooks/test_django.py::test_django[onedir]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:hooks Caused by or effecting some hook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants