Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Move tests for external modules into its own directory. #7930

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

OmarEid451
Copy link

In order to make the files slightly more manageable I moved various test files for external science modules (matplotlib, scipy, etc) as well as django into their own folder.

Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's much more to it than just moving some files around I'm afraid.

  • You'll need to update CI so that this new suite actually runs. Namely here and here.

  • Likewise in the developer docs.

  • And here so that just running pytest runs all three suites.

  • There are also resource lookups which will need to be adjusted.

@rokm
Copy link
Member

rokm commented Sep 10, 2023

Is it really worth moving those files around?

@Legorooj
Copy link
Member

While in principle I have no issues with moving tests so they're in more logical locations, I'd rather have it done in one fell swoop - one big PR to clean up the entire test suite.

@rokm
Copy link
Member

rokm commented Sep 15, 2023

I suppose split between stdlib and 3rd party libraries would make sense if we wanted to split the CI run in two steps.

Otherwise, I don't see much benefit in splitting the test suite between stdlib and 3rd party libraries; not least of all because sometimes it is difficult to draw the line between the two (i.e., if the tests are grouped by functionality rather than library).

One change I think would make sense is to move stuff from tests/functional/test_hooks into parent tests/functional, so that all tests are in the same directory, and sub-directories contain only data and auxiliary files needed by the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants