-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the polypharmacy example and GripNet implementation #346
Conversation
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 92.81% 91.38% -1.43%
==========================================
Files 46 48 +2
Lines 5078 5130 +52
==========================================
- Hits 4713 4688 -25
- Misses 365 442 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the great efforts. Almost there, with a few minor issues remaining.
Shall we ask @JunseKim1159 to help with unit tests to improve the coverage?
Why not. @JunseKim1159 will be very helpful if he is interested. Besides the code format and testing cases, he can probably help with reconstructing a new valid polypharmacy example dataset and writing the notebook! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better talk through the remaining problems to move forward. Many thanks.
self.protein_feat = data.g_feat | ||
self.protein_edge_index = data.gg_edge_index | ||
self.drug_feat = data.d_feat | ||
self.protein_drug_edge_index = data.gd_edge_index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we have corrected the above variable named. g_
, gg_
, d_
, gd_
. Is it else where? Can we make them more descriptive here? Also gene or protein, again. I saw you used protein more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to the variable name in the dataset, to be updated in another PR.
This PR will update and test the polypharmacy gripnet example and the core API related to GripNet. A tutorial notebook for Gripnet will be added in the next PR after this one is merged.
Change summary:
PolypharmacyDataset
tokale.loaddata.polypharmacy_datasets
DistMultDecoder
andGripNetLinkPrediction
tokale.predict.decode
negative_sampling
andtyped_negative_sampling
tokale.prepdata.graph_negative_sampling
out_channels
toGripNet
inkale.embed.gripnet
auprc_auroc_ap
tokale.evaluate.metrics
Follow-up future works in order of priority
g_
,gg_
,d_
,gd_
). Also be more consistent whether gene or protein.Status
Ready
Types of changes
docs
manually updated for new API.