Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypedDict instance callable #1101

Merged
merged 1 commit into from Jul 19, 2021
Merged

Make TypedDict instance callable #1101

merged 1 commit into from Jul 19, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 19, 2021

Description

Add the __call__ method to the TypedDict class to make sure TypedDict instances are callable.

Note: In Python 3.8, TypedDict was defined as class and not as function.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Ref: pylint-dev/pylint#4715

@cdce8p cdce8p added this to the 2.6.3 milestone Jul 19, 2021
@cdce8p cdce8p mentioned this pull request Jul 19, 2021
Merged
@cdce8p cdce8p added Bug 🪳 pylint-tested PRs that don't cause major regressions with pylint labels Jul 19, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit b25c6d8 into pylint-dev:main Jul 19, 2021
@cdce8p cdce8p deleted the fix-typeddict branch July 19, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug 🪳 pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdce8p @Pierre-Sassoulas