Fix false positives for invalid-all-format (#4711) (#4829)

* Fix false positives for invalid-all-format (#4711)
pylint-dev · Aug 11, 2021 · 47b483a · 47b483a
1 parent b8021d3
commit 47b483a
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 1 deletion.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -529,3 +529,5 @@ contributors:
 * Daniel van Noord (DanielNoord): contributor
 
 * Michal Vasilek: contributor
+
+* Kai Mueller (kasium): contributor
diff --git a/ChangeLog b/ChangeLog
@@ -97,6 +97,10 @@ Release date: TBA
 
   Closes #4102
 
+* Fix false postive for ``invalid-all-format`` if the list or tuple builtin functions are used
+
+  Closes #4711
+
 
 What's New in Pylint 2.9.6?
 ===========================

diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py
@@ -2010,7 +2010,7 @@ def _check_all(self, node, not_consumed):
         if assigned is astroid.Uninferable:
             return
 
-        if not isinstance(assigned, (astroid.Tuple, astroid.List)):
+        if not isinstance(assigned, (astroid.Tuple, astroid.List, list, tuple)):
             self.add_message("invalid-all-format", node=assigned)
             return
 

diff --git a/tests/functional/i/invalid/invalid_all_format_valid_3.py b/tests/functional/i/invalid/invalid_all_format_valid_3.py
@@ -0,0 +1,4 @@
+"""Test valid __all__ format."""
+__all__ = list("CONST")
+
+CONST = 42
diff --git a/tests/functional/i/invalid/invalid_all_format_valid_4.py b/tests/functional/i/invalid/invalid_all_format_valid_4.py
@@ -0,0 +1,4 @@
+"""Test valid __all__ format."""
+__all__ = tuple("CONST")
+
+CONST = 42