Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore import x.y.z as z cases for checker useless-import-alias #2402

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

sushobhit27
Copy link
Contributor

@PCManticore
Copy link
Contributor

I don't this needs to be ignored, just the message addressed to account for the from import. And maybe rename the message to something else.

@sushobhit27
Copy link
Contributor Author

I don't this needs to be ignored, just the message addressed to account for the from import. And maybe rename the message to something else.

I was thinking that current checker should check only import a as a type cases and have a different checker for cases like import a.b.c as c, which can suggest to refactor it as "from a.b import c".

This way it will be more meaningful for each checker.

@coveralls
Copy link

coveralls commented Aug 12, 2018

Coverage Status

Coverage remained the same at 90.057% when pulling f6c4407 on sushobhit27:fix_2309 into 7c103cd on PyCQA:master.

@PCManticore
Copy link
Contributor

Okay, this makes sense. We can add a separate check.

@PCManticore PCManticore merged commit 3176bbb into pylint-dev:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants