Don't reset similarities config to defaults in parallel mode #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parallel mode is used (`--jobs 0`, `--jobs 2`, ...), the `similarities` checker seems to ignore the `min-similarity-lines` config values provided by the user. Instead it seems to use the builtin default value of 4. In "serial mode" (i.e. not specifying `--jobs`), this is not an issue. The `reduce_map_data` method is a class method, so a new instance of the similarity checker is created. I narrowed down the issue to the fact that this instance is not configured. I'm not sure if this is the right way to fix this, but using the originally configured instance of this checker, instead of creating a new one, works.
shvenkat
changed the title
This was referenced Mar 4, 2021
| recombined = SimilarChecker(linter) | ||
| try: | ||
| recombined = linter._checkers["similarities"][0] | ||
| except: |
There was a problem hiding this comment.
Bare except.
Try running the following inside your checkout.
tox -e formatting
| @@ -427,7 +427,10 @@ def reduce_map_data(cls, linter, data): | |||
| """Reduces and recombines data into a format that we can report on | |||
|
|
|||
| The partner function of get_map_data()""" | |||
| recombined = SimilarChecker(linter) | |||
| try: | |||
| recombined = linter._checkers["similarities"][0] | |||
There was a problem hiding this comment.
As suggested in #4175 a better way of doing this might be to change this method from a @classmethod to an instance method. The call-site supports this.
|
Going to close this as the PR that would supersede this has been merged already. The associated issue (#4118) has also been closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parallel mode is used (
--jobs 0,--jobs 2, ...), thesimilaritieschecker seems to ignore themin-similarity-linesconfig values provided by the user. Instead it seems to use the builtin default value of 4. In "serial mode" (i.e. not specifying--jobs), this is not an issue.The
reduce_map_datamethod is a class method, so a new instance of the similarity checker is created. I narrowed down the issue to the fact that this instance is not configured. I'm not sure if this is the right way to fix this, but using the originally configured instance of this checker, instead of creating a new one, works.Steps
doc/whatsnew/<current release.rst>.Description
Type of Changes
Related Issue