Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 1070 file output #4339

Merged

Conversation

DudeNr33
Copy link
Collaborator

Steps

  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

This PR is a proposal for closing #1070.
It adds a new option --output-file which can be optionally specified.
If set, all messages and reports will be saved to the specified file instead of being printed to stdout.
It can be combined with all of the existing reporters/output formats.

Type of Changes

Type
✨ New feature

Related Issue

Closes #1070

@coveralls
Copy link

coveralls commented Apr 11, 2021

Coverage Status

Coverage increased (+0.03%) to 91.639% when pulling 1f8a2b4 on DudeNr33:enhancement-1070-file-output into 9d959ab on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label Apr 11, 2021
@Pierre-Sassoulas
Copy link
Member

I do not have the time to review everything right now, but isn't output instead of output-file possible ?

@DudeNr33
Copy link
Collaborator Author

Do you mean that the command line/pylintrc parameter should be named simple "command" instead of "output file"?
That would of course be no problem.

@Pierre-Sassoulas
Copy link
Member

I was thinking the standard when available is -o / --output for the command line option.

@DudeNr33
Copy link
Collaborator Author

I've seen both, but don't have a preference and don't know what is more common. Changed it to just --output.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change on an old issue that needed fixing :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit cdeae9c into pylint-dev:master Apr 23, 2021
@DudeNr33 DudeNr33 deleted the enhancement-1070-file-output branch April 23, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support output to a file to support tox on CI servers
3 participants