-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suggestion in helptext for unnecessary-comprehension
checker
#4500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe we could also advise "use my_list
" instead of "use list(my_list)
if it's already a set/list/dict ? :) (Yes, I've seen this this in a real code base 😄)
oops -- my bad. I'll try to incorporate those in |
…hecker Also, added typehints for checker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work again ! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Steps
doc/whatsnew/<current release.rst>
.Description
Improved help text for
unnecessary-comprehension
-- now provides suggestion of what could be used instead.E.g:
Help text:
Type of Changes
Related Issue
Closes #4499