Implemented unused-protected-member checker
#4503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketpair
reviewed
May 25, 2021
| @@ -80,6 +80,11 @@ modules are added. | |||
| * Make ``using-constant-test`` detect constant tests consisting of list literals like ``[]`` and | |||
| ``[1, 2, 3]``. | |||
|
|
|||
| * New checker ``unused-protected-member``. Emitted when a protected member (i.e., starts with ``_``) of a class | |||
There was a problem hiding this comment.
It's OK situation (not a bug). Typically such methods defined for calling in children classes.
There was a problem hiding this comment.
yep, I realise this -- which was why i closed this PR.
Correct implementation here #4504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Implemented a new checker,
unused-protected-member, which is emitted when a private member (i.e., begins with_) is defined within a class and unusedCheck includes:
Type of Changes
Related Issue
Closes #4483