Fixed false negative of consider-using-enumerate on attributes
#4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
False Negative 🦋
cdce8p
reviewed
May 25, 2021
Pierre-Sassoulas
approved these changes
May 26, 2021
Comment on lines
84
to
87
| for i, _ in enumerate(self.options_providers): | ||
| if provider.priority > self.options_providers[i].priority: | ||
| self.options_providers.insert(i, provider) | ||
| break |
There was a problem hiding this comment.
Suggested change
| for i, _ in enumerate(self.options_providers): | |
| if provider.priority > self.options_providers[i].priority: | |
| self.options_providers.insert(i, provider) | |
| break | |
| for i, options_provider in enumerate(self.options_providers): | |
| if provider.priority > options_provider.priority: | |
| self.options_providers.insert(i, provider) | |
| break |
There was a problem hiding this comment.
oops, oversight on my part -- will accept this suggestion. Thanks!
There was a problem hiding this comment.
We can probably add a new checker for it ;)
Something like list-index-lookup?
There was a problem hiding this comment.
sounds good, was thinking something along the lines too
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Fixed false negative of
consider-using-enumeratenot emitting when iterating over an attribute.Also, included test scenario described in #3657
Type of Changes
Related Issue
Closes #3657