Implemented new checker invalid-class-object

[yushao2]

Steps

• Add a ChangeLog entry describing what your PR does.
• If it's a new feature or an important bug fix, add a What's New entry in
  doc/whatsnew/<current release.rst>.
• Write a good description on what the PR does.

Description

Implemented a new checker invalid-class-object, which checks for cases where a non-class object is assigned to the __class__ attribute

Also, refactored files in functional test suite

Type of Changes

	Type
✓	✨ New feature

Related Issue

Closes #585

[yushao2]

P.S.: I'm not too familiar with working with __class__ myself, so the functional test suite might be incomplete

[coveralls]

Coverage increased (+0.005%) to 91.841% when pulling e111796 on yushao2:checkers-585 into 12af1ce on PyCQA:master.

[Pierre-Sassoulas]

Nice, that's an old issue you're fixing here !

[cdce8p]

Why did you move the tests cases? Not sure this is really necessary. If it is, it would probably be better to do it in a separate PR.

[yushao2]

Why did you move the tests cases? Not sure this is really necessary. If it is, it would probably be better to do it in a separate PR.

An error was being thrown that the invalid subfolder had too many test cases.

Maybe i can undo moving all test cases, and keep this in a subfolder. What do you think?

[Pierre-Sassoulas]

I think we can keep the file moved the way you did, it's not confusing. Maybe in another MR that we'll rebase this one on ?

[yushao2]

I think we can keep the file moved the way you did, it's not confusing. Maybe in another MR that we'll rebase this one on ?

sorry, so I should leave the files as how i moved them in this MR? just to clarify

[Pierre-Sassoulas]

Yes, looks fine to me, there is a lot of functional tests starting by "invalid" so separating them again like you did make sense.

[yushao2]

Yes, looks fine to me, there is a lot of functional tests starting by "invalid" so separating them again like you did make sense.

for now, in this MR, i separated only those with > 2 files so that it would not be too heavy on the refactoring

[cdce8p]

Ok, let's merge it then!