Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore-paths to match against the full path. #4516

Merged
merged 13 commits into from
May 27, 2021
Merged

Add ignore-paths to match against the full path. #4516

merged 13 commits into from
May 27, 2021

Conversation

fdamken
Copy link
Contributor

@fdamken fdamken commented May 26, 2021 •
edited

This PR is a relaunch of #3266 as the original author (@bernardn) does not respond anymore.

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Add ignore-paths configuration directive. Checks against full file path.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #2541
Closes #2686

@fdamken fdamken changed the title Add ignore-paths to match against the full path Add ignore-paths to match against the full path. May 26, 2021
@fdamken fdamken mentioned this pull request May 26, 2021
Closed
@coveralls
Copy link

coveralls commented May 26, 2021 •
edited

Coverage Status

Coverage increased (+0.0006%) to 91.841% when pulling d191344 on fdamken:issue/2541 into 0b5a443 on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 26, 2021
Closed
4 tasks
@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label May 26, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for rebasing this ! Feel free to take my comment into account (and add yourself to the contributor :) ) or not. I think this was well reviewed originally and I don't have any comments myself so this look mergeable.

pylint/lint/expand_modules.py Outdated Show resolved Hide resolved
@fdamken
Copy link
Contributor Author

fdamken commented May 26, 2021 •
edited

I'll check on the errors regarding the AttributeError: module 're' has no attribute 'Pattern'.

@Pierre-Sassoulas
Copy link
Member

I think you need from typing import Pattern instead.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5805a73 into pylint-dev:master May 27, 2021
@Pierre-Sassoulas
Copy link
Member

Thank you again for rebooting this, merging it after all this time in review is nice :)

@jamesbraza jamesbraza mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore clause not ignoring directories ignore-patterns does not skip non-top-level directories.
4 participants
@fdamken @coveralls @Pierre-Sassoulas @bernardn