-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression tests for Enum.name and .value inference #4558
Add regression tests for Enum.name and .value inference #4558
Conversation
@nelfin Feel free to add Lastly, I saw by accident that #2306 appears to be fixed as well, at least for Python < 3.10. Something changed of for 3.10 though. |
This PR doesn't actually fix those issues though?
Sure.
The implementation of |
e50b5bb
to
685f410
Compare
I thought it did. If you meant that pylint-dev/astroid#1020 actually fixed it, that is no problem. I frequently use
Thanks 👍🏻 |
That is what I meant. I've updated the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@nelfin Thanks for fixing the issue with 3.10! Would you mind adding the regression test for it here? Just so we don't lose it |
Steps
Add yourself to CONTRIBUTORS if you are a new contributor.If it's a new feature or an important bug fix, add a What's New entry in
doc/whatsnew/<current release.rst>
.Description
Captures the regression tests specified in #1932 and #2062 and fixed by pylint-dev/astroid#1020.
Type of Changes
Related Issue
Closes #1932. Closes #2062. Depends on pylint-dev/astroid#1020.