Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when a test function is decorated with @pytest.fixture #4613

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jun 23, 2021

Description

And astroid can't infer the name of the decorator when using open without with inside the function.

Type of Changes

Type
βœ“ πŸ› Bug fix

Closes #4612

@Pierre-Sassoulas Pierre-Sassoulas added Blocker πŸ™… Blocks the next release Crash πŸ’₯ A bug that makes pylint crash labels Jun 23, 2021
@coveralls
Copy link

coveralls commented Jun 23, 2021

Coverage Status

Coverage remained the same at 92.012% when pulling 0a884d9 on Pierre-Sassoulas:fix-crash-with-pytest-fixture into eba42d0 on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.0 milestone Jun 23, 2021
And astroid can't infer the name of the decorator when using ``open``
without ``with``.

Closes pylint-dev#4612
@Pierre-Sassoulas Pierre-Sassoulas merged commit 93d6c39 into pylint-dev:master Jun 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-crash-with-pytest-fixture branch June 23, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker πŸ™… Blocks the next release Crash πŸ’₯ A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when a test function is decorated with @pytest.fixture
2 participants