Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive unused-private-member if class member is accessed via self #4645

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Fix false positive unused-private-member if class member is accessed via self #4645

merged 3 commits into from
Jul 1, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Description

The self was forgotten. Also made some small refactor around it following comment made in #4642

Type of Changes

Type
✓ 🐛 Bug fix
✓ 🔨 Refactoring

Related Issue

Closes #4644

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jul 1, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.2 milestone Jul 1, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 92.038% when pulling 1ae9088 on Pierre-Sassoulas:unused-private-member-v2 into cec5b17 on PyCQA:main.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 472f25e into pylint-dev:main Jul 1, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the unused-private-member-v2 branch July 1, 2021 07:31
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

False positive unused-private-member if class member is accessed via self
2 participants
@Pierre-Sassoulas @coveralls