Fix false-positive consider-using-with when using contextlib.ExitStack

[DudeNr33]

Steps

• Add a ChangeLog entry describing what your PR does.
• If it's a new feature or an important bug fix, add a What's New entry in
  doc/whatsnew/<current release.rst>.
• Write a good description on what the PR does.

Description

The contextlib.ExitStack class provides a method to automatically call __exit__ on context managers added to its stack when leaving a with contextlib.ExitStack() as stack block.
If a callable that could be used in a with block was added to the stack, no R1732 consider-using-with message should be triggered:

with contextlib.ExitStack() as stack:
    _ = stack.enter_context(
        open("/sys/firmware/devicetree/base/hwid,location", "r")
    )  # must not trigger

While contextlib.AsyncExitStack should theoretically also be covered (as it can be used with synchronous context managers as well), it is currently not possible to implement this, as trying to infer the stack.enter_context returns Uninferable in this case...

I also noticed that the whole consider-using-with check does not check asynchronous context managers at all.
But I guess this would exceed the scope of this PR, and should probably get its own message (e.g. consider-using-async-with).

Type of Changes

	Type
✓	🐛 Bug fix

Related Issue

Closes #4654

[Pierre-Sassoulas]

I juste have a minor comment about the documentation, thanks a lot for the fix and for the clean tests and implementation !

[coveralls]

Coverage decreased (-0.003%) to 92.038% when pulling 23b628e on DudeNr33:issue-4654-false-positive-r1732 into c026826 on PyCQA:main.

[cdce8p]

Looks good! Two small comments

[cdce8p]

Suggested change

Empty line :)

[cdce8p]

As it's just used two times, it's probably better to write out node.parent directly. That way you don't have to think about it.

[DudeNr33]

Thank you both for the feedback, the latest commit should cover all requested changes!

[Pierre-Sassoulas]

Thank you for this fix, it will be released in 2.9.4 :)