Fix false-positive of use-maxsplit-arg when index is incremented inside a loop
#4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushao2
added
the
False Positive 🦟
cdce8p
approved these changes
Jul 4, 2021
| if isinstance(node.parent.slice, astroid.Name): | ||
| # Check if loop present within the scope of the node | ||
| scope = node.scope() | ||
| for loop_node in scope.nodes_of_class((astroid.For, astroid.While)): |
There was a problem hiding this comment.
Could you add type hints for loop_node and assignment_node below (with typing.cast).
I should probably add types to NodeNG.nodes_of_class soon, so we don't need to anymore.
| source = 'A.B.C.D.E.F.G' | ||
| other_iterable = range(5) | ||
| i = 0 | ||
| for j in other_iterable: |
There was a problem hiding this comment.
Suggested change
| for j in other_iterable: | |
| for j in range(5): |
I would simplify it a bit
| use-maxsplit-arg:82:4::Use '1,2,3'.split('\n', maxsplit=1)[0] instead | ||
| use-maxsplit-arg:83:4::Use '1,2,3'.rsplit('split', maxsplit=1)[-1] instead | ||
| use-maxsplit-arg:84:4::Use '1,2,3'.split('rsplit', maxsplit=1)[0] instead | ||
| use-maxsplit-arg:5:12::Use '1,2,3'.split(',', maxsplit=1)[0] instead:HIGH |
There was a problem hiding this comment.
Just my opinion, but I'm not a big fan of adding :HIGH and creating larger diffs than necessary. That makes it quite difficult to review.
Pierre-Sassoulas
approved these changes
Jul 4, 2021
yushao2
force-pushed
the
fix-use-maxsplit-arg
branch
from
6cc9b52
to
9706392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Handle case where variable subscripts are mutated within a loop, see #4664
Minor refactoring to if/else logic as there were linting issues where there's too much if/else nesting
Type of Changes
Related Issue
Closes #4664