New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute import qualified module name for deprecated module check #4678
Use absolute import qualified module name for deprecated module check #4678
Conversation
Pending:
|
a6c1278
to
f9cf192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this ! I did not know that it was possible to create packages in the functional tests, good to know. (It means we could migrate the old functional test entirely).
@@ -0,0 +1,2 @@ | |||
[testoptions] | |||
min_pyver=3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't required because the min supported version is python 3.6 anyway. (I'm saying this so you don't have to do it next time, no need to change that :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you good to know. I saw that other tests include even older version of python than supported by pylint, so I considered it as a practise to put it there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should probably clean up when we stop supporting Python 3.6, because this is confusing. I don't think anyone will fork to support a lower version of Python than us anyway. I'm going to open an issue.
Me neither, I just tried and it worked :-D. |
Steps
doc/whatsnew/<current release.rst>
.Description
This PR adjust deprecated module check of from imports to use absolute import name. It helps avoid detecting deprecated
modules in relative imports.
Type of Changes
Related Issue
Closes #4629