Add a functional tests for 4685 #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Work in progress
Crash 💥
Pierre-Sassoulas
force-pushed
the
regression-tests-for-4685
branch
from
55795fb
to
de78331
Compare
|
@cdce8p here's the first crash with python 3.10 😄 ! Someone is using it 🎉 |
That is the only way we'll catch them all 😄 -- |
Pierre-Sassoulas
added
the
Needs astroid update
Pierre-Sassoulas
force-pushed
the
regression-tests-for-4685
branch
from
de78331
to
5833fc5
Compare
cdce8p
force-pushed
the
regression-tests-for-4685
branch
from
5833fc5
to
a806175
Compare
|
@Pierre-Sassoulas I've updated the PR to use the test cases mentioned in pylint-dev/astroid#1093. Does that work for you? I could revert the commits to restore the original test case, but I believe the current one is more precise and even covers more errors. |
|
Sure, no problem ! |
Pierre-Sassoulas
force-pushed
the
regression-tests-for-4685
branch
from
a1dcef4
to
837bb43
Compare
Pierre-Sassoulas
force-pushed
the
regression-tests-for-4685
branch
from
837bb43
to
1bc0350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a functional test for a python 3.10 crash that occurred when inferring variables assigned in match patterns.
Type of Changes
Related Issue
Issue fixed with: pylint-dev/astroid#1093
Closes #4685