Fix false-positive of unused-private-member with class name

[yushao2]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Simple fix to avoid false-positive to check for private attributes and do not emit if it was called with the Class's name.

Done by using a boolean condition and comparing it to the node's (classdef) name

Also, added a pylint ignore as more boolean expressions are needed here

Closes #4681

[coveralls]

Coverage increased (+0.004%) to 92.269% when pulling 0dcfd89 on yushao2:fix-unused-private-member-4681 into 2ad8247 on PyCQA:main.

[cdce8p]

Left some comments. Additionally I noticed that _check_unused_private_attributes doesn't have typing.cast after nodes_of_class. Maybe you would like to add it with this change (two times).

--
One more thing, just so you know. For PRs it doesn't make much sense to assign yourself if you are already the author. I usually assign myself if I want to show that I'll review a PR from someone else and what to help see it through.

[cdce8p]

Looks good! I also like the additional test case you added 🚀

[Pierre-Sassoulas]

Thank you !

[yumasheta]

Hello there!

Shouldn't this PR also fix:

class UnusedPrivateMember:
    """unused-private-member (W0238)"""

    @staticmethod
    def __private_method():
        """Is private and does nothing."""

    @classmethod
    def use_private_method(cls):
        """Calls private method."""
        cls.__private_method()

which produces:

W0238: Unused private member `UnusedPrivateMember.__private_method()` (unused-private-member)

I'm running the latest master branch:

pylint 2.10.0-dev0
astroid 2.6.6
Python 3.9.6 (default, Jun 30 2021, 10:22:16) 
[GCC 11.1.0]

Note, when using a class attribute (i.e. change __private_method to an attr) it does work as expected.

[cdce8p]

@yumasheta Can you open a new issue for it? That way we are better able to track it