Add redundant-u-string-prefix checker
#4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a checker for u-prefixes for strings, as used in Python 2. Closes pylint-dev#4102
DanielNoord
commented
Aug 5, 2021
| @@ -89,10 +89,14 @@ Release date: TBA | |||
|
|
|||
| Closes #626 | |||
|
|
|||
| * Add ``disable-next`` option: allows using `# pylint: disable-next=msgid` to disable a message for the following line | |||
| * Added ``disable-next`` option: allows using `# pylint: disable-next=msgid` to disable a message for the following line | |||
There was a problem hiding this comment.
All other changes also use past tense
Pierre-Sassoulas
added
Checkers
Pierre-Sassoulas
approved these changes
Aug 5, 2021
|
Could a maintainer force re-run the checks? Something went wrong with the runners I think.. |
|
I relaunched, CodeQL failed again but it's not a mandatory check. The pypy one seems genuine. |
|
Oops, looks like I forgot to run the test suite locally. I think I didn't expect pylint to use u-prefixes.. 😅 |
|
Turns out |
|
I don't know if it would be "easy" or "elegant", but it would be a change in astroid. Maybe we can do this check only in python 3.8+ ? |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
This adds a checker for u-prefixes for strings, as used in Python 2.
Closes #4102