Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on relative import beyond top-level package #4848

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #4775

@Pierre-Sassoulas Pierre-Sassoulas added Bug πŸͺ² Blocker πŸ™… Blocks the next release Crash πŸ’₯ A bug that makes pylint crash labels Aug 15, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Aug 15, 2021
@coveralls
Copy link

coveralls commented Aug 15, 2021

Pull Request Test Coverage Report for Build 1133248726

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 92.733%

Totals Coverage Status
Change from base Build 1133179354: 0.002%
Covered Lines: 13411
Relevant Lines: 14462

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-crash-with-relative-import-in-from-statement branch from 9e15aba to a2ca7df Compare August 15, 2021 18:46
@Pierre-Sassoulas Pierre-Sassoulas merged commit 74ea145 into pylint-dev:main Aug 15, 2021
andreasgerstmayr added a commit to andreasgerstmayr/pcp that referenced this pull request Aug 24, 2021
Due to pylint-dev/pylint#4848 pylint >= v2.10.0 is required to parse the
sources.
andreasgerstmayr added a commit to andreasgerstmayr/pcp that referenced this pull request Aug 24, 2021
Due to pylint-dev/pylint#4848 pylint >= v2.10.0 is required to parse the
sources.
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-crash-with-relative-import-in-from-statement branch October 16, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker πŸ™… Blocks the next release Bug πŸͺ² Crash πŸ’₯ A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with relative import in from statement
2 participants