Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[duplicate-code] Parse functions and class methods recursively when gathering signature lines #4858

Merged
merged 2 commits into from Aug 17, 2021
Merged

[duplicate-code] Parse functions and class methods recursively when gathering signature lines #4858

merged 2 commits into from Aug 17, 2021

Conversation

mhumetskyi
Copy link
Contributor

Ignore class methods' and nested functions' signatures the same way as functions' with similarities "ignore-signatures" option enabled.

Type of Changes

Type
✓ ✨ New feature

Description

Closes #4653

@coveralls
Copy link

coveralls commented Aug 17, 2021 •
edited

Pull Request Test Coverage Report for Build 1140348536

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 92.741%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/similar.py 6 96.31%
Totals Coverage Status
Change from base Build 1136289990: 0.004%
Covered Lines: 13427
Relevant Lines: 14478
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component duplicate-code Related to code duplication checker labels Aug 17, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Aug 17, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this :) ! Could you add some typing for the new function ? We're trying to introduce it little by little.

pylint/checkers/similar.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas merged commit ef72cdc into pylint-dev:main Aug 17, 2021
@Pierre-Sassoulas
Copy link
Member

Thank you again, this will be available in 2.10.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
duplicate-code Related to code duplication checker Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Ignore class methods signatures with similarities "ignore-signatures" option enabled
3 participants
@mhumetskyi @coveralls @Pierre-Sassoulas