Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive unused-private-member for accessing attributes in a class using cls #4965

Merged
merged 6 commits into from Sep 14, 2021
Merged

Fix false positive unused-private-member for accessing attributes in a class using cls #4965

merged 6 commits into from Sep 14, 2021

Conversation

yushao2
Copy link
Collaborator

@yushao2 yushao2 commented Sep 4, 2021

Type of Changes

Type
✓ 🐛 Bug fix

Description

Fix false positive for unused-private-member when accessing attribs in class using cls by extending logic

Closes #4681

@yushao2 yushao2 added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Sep 4, 2021
@yushao2 yushao2 added this to the 2.11.0 milestone Sep 4, 2021
@coveralls
Copy link

coveralls commented Sep 4, 2021 •
edited

Pull Request Test Coverage Report for Build 1224997812

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 93.073%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/classes.py 1 94.55%
Totals Coverage Status
Change from base Build 1224895625: -0.007%
Covered Lines: 13248
Relevant Lines: 14234
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Sep 4, 2021
Merged
@Pierre-Sassoulas
Copy link
Member

@yushao2 is this ready for review ? We might want to do the refactor later so we can ship this in pylint 2.11.

@yushao2
Copy link
Collaborator Author

yushao2 commented Sep 14, 2021

@yushao2 is this ready for review ? We might want to do the refactor later so we can ship this in pylint 2.11.

yep, please go ahead and let me know of any feedback :)

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit 272596b into pylint-dev:main Sep 14, 2021
@yushao2 yushao2 deleted the false-positive-4681 branch September 14, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p Awaiting requested review from cdce8p

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

False-positive unused-private-member with class name
3 participants
@yushao2 @coveralls @Pierre-Sassoulas