Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with cache's parent directory not existing #4988

Merged
merged 1 commit into from Sep 10, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

By changing the function used to create the cache from os.mkdir to os.makedirs we now handle non-existing parent directories correctly.
This closes #4900

This was one of the final open issues on the 2.11.0 milestone! πŸ˜„

By changing the function used to create the cache from ``os.mkdir``
to ``os.makedirs`` we now handle non-existing parent directories
correctly.
This closes pylint-dev#4900
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1220331199

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 93.084%

Files with Coverage Reduction New Missed Lines %
pylint/config/init.py 4 71.01%
Totals Coverage Status
Change from base Build 1214643287: -0.03%
Covered Lines: 13244
Relevant Lines: 14228

πŸ’› - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@Pierre-Sassoulas Pierre-Sassoulas merged commit e777697 into pylint-dev:main Sep 10, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 10, 2021
@DanielNoord DanielNoord deleted the cache-directory branch September 13, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint prints error about cache files in fresh environment with pylint 2.10.2
3 participants