Make global-variable-not-assigned check local scope
#4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checker now checks whether the names after the global keyword are reassigned in the local scope. This closes pylint-dev#1375
Pull Request Test Coverage Report for Build 1224244856
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Sep 10, 2021
Pierre-Sassoulas
added
Bug 🪲
False Negative 🦋
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
This checker now also checks function defintions in the module and local scope This closes pylint-dev#330
|
Sorry for adding changes after your review, but I stumbled upon #330 and it felt weird not to fix it in the same PR. Because #330 also indicated that function definition in the module scope were not picked up on by the check for |
|
Don't worry, thank you for fixing another problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
This checker now checks whether the names after the global keyword are reassigned in the local scope.
I created a small
utilsfunction that checks whether the name appears in any of theAssignNamenodes in the scope.The updated test only throws an error for 2 of the 4 variables. Not quite sure what that is about and we might want to make another issue/PR to fix that. However, since the change did not break any of the tests the file is designed for I guessed it was okay for now. This PR does fix the original issue.
This closes #1375
This closes #330