Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure a tool table is created in toml generation #8638

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Make sure a tool table is created in toml generation #8638

merged 3 commits into from
Apr 30, 2023

Conversation

DanielNoord
Copy link
Collaborator

Type of Changes

Type
✓ 🐛 Bug fix

Description

Reverts #8633
Fixes #8632

@DanielNoord DanielNoord added dependency Label for github dependabot backport maintenance/3.2.x labels Apr 30, 2023
@DanielNoord DanielNoord added this to the 2.17.4 milestone Apr 30, 2023
@DanielNoord DanielNoord added the Skip news 🔇 This change does not require a changelog entry label Apr 30, 2023
@DanielNoord DanielNoord mentioned this pull request Apr 30, 2023
Merged
@codecov
Copy link

codecov bot commented Apr 30, 2023 •
edited

Codecov Report

Merging #8638 (2d97d0b) into main (1cbc3d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8638   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         174      174           
  Lines       18319    18321    +2     
=======================================
+ Hits        17552    17554    +2     
  Misses        767      767
Impacted Files Coverage Δ
pylint/config/arguments_manager.py 100.00% <100.00%> (ø)

Pierre-Sassoulas
Pierre-Sassoulas requested changes Apr 30, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the "real" fix :D

doc/user_guide/configuration/all-options.rst Outdated Show resolved Hide resolved
@DanielNoord @Pierre-Sassoulas
Update doc/user_guide/configuration/all-options.rst
2d97d0b 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@DanielNoord DanielNoord enabled auto-merge (squash) April 30, 2023 15:26
@DanielNoord DanielNoord merged commit 434d49f into pylint-dev:main Apr 30, 2023
32 of 34 checks passed
@DanielNoord DanielNoord deleted the tomlkit branch April 30, 2023 15:32
github-actions bot pushed a commit that referenced this pull request Apr 30, 2023
@DanielNoord @github-actions
Make sure a tool table is created in toml generation (#8638)
251fcc9 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 434d49f)
@github-actions github-actions bot mentioned this pull request Apr 30, 2023
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Apr 30, 2023
@github-actions @DanielNoord
Make sure a tool table is created in toml generation (#8638) (#…
fd60b72 
…8640)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 434d49f)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported dependency Label for github dependabot Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
2.17.4
Development

Successfully merging this pull request may close these issues.

TOMLKitError when generating TOML config with tomlkit 0.11.8
2 participants
@DanielNoord @Pierre-Sassoulas