New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [unknown-option-value] False negative after --disable=all #9491
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
for more information, see https://pre-commit.ci
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 302e513 |
self._runtest([UNNECESSARY_LAMBDA, "--disable=all"], out=out, code=0) | ||
assert "Your code has been rated at 10.00/10" in out.getvalue().strip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fellhorn, thanks for picking this up. I think we should find a solution that does not cause this test to fail. If you look at the blame for this line, we're trying to alert the user that they perhaps accidentally disabled all messages. We need to ignore the set of "pylint's own messages" when making that determination so that we can continue to check "accidentally disabled everything but pylint's own messages" if that makes sense.
This PR needs take over because because it has been open 8 weeks with no activity. |
I plan to take another look but lately had not really much capacity. If the issue is urgent though, please feel free to take over. |
Type of Changes
Description
Closes #9403 by excluding a set of internal pylint messages from
--disable=all
.As this is my first PR to pylint I appreciate any comment on the solution. Especially in regards of the message codes and having to change an existing test.