Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Check that 'trailing-comma-tuple' is enabled only once #9620

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented May 13, 2024

Type of Changes

Type
✨ New feature
📜 Docs

Description

Performance analysis by @correctmost. Follow up to fix the known limitation will be in #9609

Refs #8606 (follow-up)
Closes #9608

Performance analysis by correctmost.  Follow up to fix the known limitation will be in pylint-dev#9609

Refs pylint-dev#8606 (follow-up)
Closes pylint-dev#9608
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (4f0c7ac) to head (7548744).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9620   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files         174      174           
  Lines       18888    18889    +1     
=======================================
+ Hits        18102    18103    +1     
  Misses        786      786           
Files Coverage Δ
pylint/checkers/refactoring/refactoring_checker.py 98.27% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 7548744

@jacobtylerwalls jacobtylerwalls merged commit 743a04d into pylint-dev:main May 13, 2024
44 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the optimization-without-bug-fix branch May 14, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R1707 (trailing-comma-tuple) checks perform excessive is_message_enabled calls
2 participants