-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker image and push to GHCR #230
Open
br3ndonland
wants to merge
10
commits into
pypa:unstable/v1
Choose a base branch
from
br3ndonland:ghcr
base: unstable/v1
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 16, 2024
-
Build Docker image and push to GHCR
Up to this point, the project has been set up as a Docker action referencing the Dockerfile. The downside to using the Dockerfile for the action is that the Docker image must be built every time the action is used. This commit will set up the project to build the Docker image and push it to GitHub Container Registry (GHCR). This change will speed up user workflows every time the action is used because the workflows will simply pull the Docker image from GHCR instead of building again. Changes: - Add required metadata to Dockerfile - Build container image with GitHub Actions - Push container image to GHCR Docker actions support pulling in pre-built Docker images. The downside is that there's no way to specify the correct Docker tag because the GitHub Actions `image` and `uses:` keys don't accept any context. For example, if a user's workflow has `uses: pypa/gh-action-pypi-publish@release/v1.8`, then the action should pull in a Docker image built from the `release/v1.8` branch, something like `ghcr.io/pypa/gh-action-pypi-publish:release-v1.8` (Docker tags can't have `/`). The workaround is to switch the top-level `action.yml` to a composite action that then calls the Docker action, substituting the correct image name and tag.
Configuration menu - View commit details
-
Copy full SHA for 9756850 - Browse repository at this point
Copy the full SHA 9756850View commit details -
Configuration menu - View commit details
-
Copy full SHA for 769f499 - Browse repository at this point
Copy the full SHA 769f499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3384fad - Browse repository at this point
Copy the full SHA 3384fadView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ae1850 - Browse repository at this point
Copy the full SHA 9ae1850View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b535ae - Browse repository at this point
Copy the full SHA 1b535aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 213c885 - Browse repository at this point
Copy the full SHA 213c885View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f0743b - Browse repository at this point
Copy the full SHA 5f0743bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 049447a - Browse repository at this point
Copy the full SHA 049447aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fb692b - Browse repository at this point
Copy the full SHA 2fb692bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30c8fae - Browse repository at this point
Copy the full SHA 30c8faeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.