test: Expand testing for wheel multi-version multi-platform #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
requested changes
Nov 9, 2022
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
|
@jacobdr please refresh my review when you're ready for me to have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this past week's issue with
wheel==0.38, this adds slightly more testing to help guard against a similar issue in this package. While its somewhat duplicative of what might already be tested intest_tags.py, since this is the most natural place to put an "end-user" consumption test (viz the internals), I thought the juice was worth the squeeze as a defensive test.I submitted a PR with similar testing to the
wheelpackage via pypa/wheel#486, but since the intention is to havewheeldepend onpackagingeventually, I also wanted to make a similar contribution here.