Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide FORCE_COLOR=1 to the CI, to colorize Nox #10830

Merged
merged 1 commit into from Jan 27, 2022

Conversation

DiddiLeija
Copy link
Member

This is just a preference. We are approaching a new Nox ability to accept an environment variable (FORCE_COLOR, which is also used by other packages) to colorize itself. See wntrblm/nox#502 and wntrblm/nox#524.

This is just a preference, I'm approaching a new Nox ability.
@DiddiLeija DiddiLeija added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 25, 2022
@DiddiLeija
Copy link
Member Author

To see how this looks, see the following steps: docs, packaging and tests (all of them).

@DiddiLeija DiddiLeija added the C: automation Automated checks, CI etc label Jan 26, 2022
@DiddiLeija
Copy link
Member Author

Any comments on this?

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@pradyunsg pradyunsg merged commit fdba4c2 into pypa:main Jan 27, 2022
@DiddiLeija DiddiLeija deleted the nox-force-color branch January 27, 2022 23:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants