Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Make CRS methods inheritable #902

Merged
merged 1 commit into from Aug 17, 2021
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Aug 15, 2021

Notes:

  • The from_* methods were changed to bypass the __init__ method. It also validates that it creates the expected type (Idea from CRS classmethods changed to staticmethods #847 (comment)).
  • The CRS properties were overridden to return a CRS. The reason for this is because the type of the CRS returned from that type is not guaranteed to always be the type of the original CRS.

@snowman2 snowman2 added this to In progress in 3.2.0 Release via automation Aug 15, 2021
@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #902 (ea2cc18) into master (43b7cff) will increase coverage by 0.06%.
The diff coverage is 98.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
+ Coverage   95.29%   95.35%   +0.06%     
==========================================
  Files          21       21              
  Lines        1680     1724      +44     
==========================================
+ Hits         1601     1644      +43     
- Misses         79       80       +1     
Impacted Files Coverage Δ
pyproj/crs/crs.py 97.71% <98.80%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b7cff...ea2cc18. Read the comment docs.

@snowman2 snowman2 force-pushed the build_crs branch 3 times, most recently from 6f642d4 to fb4133a Compare August 16, 2021 01:07
@snowman2 snowman2 marked this pull request as ready for review August 16, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

CRS classmethods changed to staticmethods
1 participant