Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Rename _MakerCRS to CustomConstructorCRS and make public #912

Merged
merged 1 commit into from Aug 24, 2021

Conversation

snowman2
Copy link
Member

With the change in #902, the base class CustomConstructorCRS is useful for other libraries such as cartopy which have a different __init__:

@snowman2 snowman2 added this to In progress in 3.2.0 Release via automation Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #912 (1a94461) into master (c4cdc33) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   96.18%   96.23%   +0.05%     
==========================================
  Files          21       21              
  Lines        1755     1755              
==========================================
+ Hits         1688     1689       +1     
+ Misses         67       66       -1     
Impacted Files Coverage Δ
pyproj/crs/__init__.py 100.00% <ø> (ø)
pyproj/crs/crs.py 97.98% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cdc33...1a94461. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant