Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: warn when export of CRS returns None #1037

Merged
merged 7 commits into from Mar 26, 2022
Merged

Conversation

martinfleis
Copy link
Contributor

@martinfleis martinfleis commented Mar 24, 2022

@snowman2
Copy link
Member

Mind adding a warning filter here:

auth_info = self.to_authority(min_confidence=100)
?

@martinfleis
Copy link
Contributor Author

All done.

@martinfleis
Copy link
Contributor Author

I don't think that I caused this CI failure.

@snowman2
Copy link
Member

I don't think that I caused this CI failure.

I agree. Looks like a jinja2 issue with the docs build that is unrelated.

@martinfleis, this looks great, thanks again👍

Would you like to squash your commits or would it be fine to squash & merge?

@snowman2
Copy link
Member

#1038 should address the docs build issue.

@martinfleis
Copy link
Contributor Author

Would you like to squash your commits or would it be fine to squash & merge?

Squash & merge is fine.

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1037 (bc69738) into main (220724a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   96.26%   96.27%           
=======================================
  Files          20       20           
  Lines        1768     1771    +3     
=======================================
+ Hits         1702     1705    +3     
  Misses         66       66           
Impacted Files Coverage Δ
pyproj/crs/crs.py 97.98% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220724a...bc69738. Read the comment docs.

@snowman2 snowman2 merged commit 5cd3d7f into pyproj4:main Mar 26, 2022
@snowman2
Copy link
Member

Thanks @martinfleis 👍

@snowman2 snowman2 added this to In progress in 3.3.1 Release via automation Mar 26, 2022
@snowman2 snowman2 moved this from In progress to Done in 3.3.1 Release Mar 26, 2022
@martinfleis martinfleis deleted the warnings branch March 26, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants