New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: warn when export of CRS returns None #1037
Conversation
Mind adding a warning filter here: Line 447 in ce9de36
|
All done. |
I don't think that I caused this CI failure. |
I agree. Looks like a jinja2 issue with the docs build that is unrelated. @martinfleis, this looks great, thanks again👍 Would you like to squash your commits or would it be fine to squash & merge? |
#1038 should address the docs build issue. |
Squash & merge is fine. |
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 96.26% 96.27%
=======================================
Files 20 20
Lines 1768 1771 +3
=======================================
+ Hits 1702 1705 +3
Misses 66 66
Continue to review full report at Codecov.
|
Thanks @martinfleis 👍 |
history.rst
for all changes andapi/*.rst
for new API