Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Complete database stub file with query_utm_crs_info() signature #1047

Merged
merged 1 commit into from Mar 31, 2022

Conversation

orontee
Copy link
Contributor

@orontee orontee commented Mar 31, 2022

Tested with:

  • Make an editable install of current PR code
  • Move to directory build in issue description and run mypy from there
(env) matthias@carbon:~/Sources/pyproj$ pushd ../../pyproj_issue/
~/pyproj_issue ~/Sources/pyproj
(env) matthias@carbon:~/pyproj_issue$ mypy test.py 
Success: no issues found in 1 source file

@snowman2
Copy link
Member

Thanks @orontee 👍. Would you like to squash your commits or would you mind if I squash on merge?

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1047 (efca47f) into main (1ca11c2) will not change coverage.
The diff coverage is n/a.

❗ Current head efca47f differs from pull request most recent head 0891756. Consider uploading reports for the commit 0891756 to get more accurate results

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          20       20           
  Lines        1771     1771           
=======================================
  Hits         1705     1705           
  Misses         66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca11c2...0891756. Read the comment docs.

@snowman2 snowman2 added this to In progress in 3.3.1 Release via automation Mar 31, 2022
@orontee
Copy link
Contributor Author

orontee commented Mar 31, 2022 via email

@orontee
Copy link
Contributor Author

orontee commented Mar 31, 2022

The squash is done.

@snowman2 snowman2 changed the title Complete database stub file with query_utm_crs_info() signature BUG: Complete database stub file with query_utm_crs_info() signature Mar 31, 2022
@snowman2 snowman2 merged commit 43e49b7 into pyproj4:main Mar 31, 2022
3.3.1 Release automation moved this from In progress to Done Mar 31, 2022
@snowman2
Copy link
Member

Thanks @orontee 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

query_utm_crs_info is missing from type stub for pyproj.database
2 participants