ENH: Added support for int-like strings and numpy dtypes

[iboates]

• Closes CRS.from_user_input does not accept numpy-integers #1026
• Closes ENH: Handle case when the SRID is just an integer, but defined as a string (e.g. "2972" instead of 2972) #1035
• Tests added
• Fully documented, including history.rst for all changes and api/*.rst for new API

I don't think api/* needs updating but maybe I am wrong.

[snowman2]

Thoughts about instead adding a method called _is_epsg_code to check for numpy scalar, integer, or integer string and passing it into from_epsg?

CRS.from_epsg should be able to handle them if they are detected properly:

>>> from pyproj import CRS
>>> import numpy
>>> CRS.from_epsg(numpy.array(4326))
<Geographic 2D CRS: EPSG:4326>
Name: WGS 84
Axis Info [ellipsoidal]:
- Lat[north]: Geodetic latitude (degree)
- Lon[east]: Geodetic longitude (degree)
Area of Use:
- name: World.
- bounds: (-180.0, -90.0, 180.0, 90.0)
Datum: World Geodetic System 1984 ensemble
- Ellipsoid: WGS 84
- Prime Meridian: Greenwich
>>> CRS.from_epsg("4326")
<Geographic 2D CRS: EPSG:4326>
Name: WGS 84
Axis Info [ellipsoidal]:
- Lat[north]: Geodetic latitude (degree)
- Lon[east]: Geodetic longitude (degree)
Area of Use:
- name: World.
- bounds: (-180.0, -90.0, 180.0, 90.0)
Datum: World Geodetic System 1984 ensemble
- Ellipsoid: WGS 84
- Prime Meridian: Greenwich

[iboates]

@snowman2 Indeed a _from_epsg_code function is cleaner. But I am not sure what to specify as its parameter type, since it could be a numpy dtype, so wouldn't object be the only choice? and therefore make it irrelevant?

[snowman2]

D

@snowman2 Indeed a _from_epsg_code function is cleaner. But I am not sure what to specify as its parameter type, since it could be a numpy dtype, so wouldn't object be the only choice? and therefore make it irrelevant?

I like the current implementation, it looks good 👍.

I think this would be sufficient:

def _is_epsg_code(auth_code: Any) -> bool:

[snowman2]

@iboates would you like to squash your commits or would you mind if I did it on merge?

[iboates]

@snowman2 You can do it on merge it's fine

[iboates]

Realized that there was an elif after a return and the linter didnt like that

[codecov]

Codecov Report

Merging #1049 (d54b811) into main (a463636) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   96.27%   96.29%   +0.01%     
==========================================
  Files          20       20              
  Lines        1771     1779       +8     
==========================================
+ Hits         1705     1713       +8     
  Misses         66       66              

Impacted Files	Coverage Δ
pyproj/crs/crs.py	98.01% <100.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a463636...d54b811. Read the comment docs.

[snowman2]

Thanks @iboates 👍