UnixConsole: raise EOFError in case input_fd is not a TTY #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly related pytest issue pytest-dev/pytest#5189. |
This is required for when the UnixConsole instance was created with stdin being a terminal, but then later not so anymore. E.g. having used pdbpp before pytest captures output (`pdb.set_trace()`), and then continuing (`c`). pytest is capturing output by now then, but the debugging plugin (which suspends capturing) might not be active yet (pytest_load_initial_conftests). This patch makes it raise `BdbQuit` then "correctly".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for when the UnixConsole instance was created with
stdin being a terminal, but then later not so anymore.
E.g. having used pdbpp before pytest captures output, and then having a
set_trace where pytest is capturing output, but the debugging plugin
(which suspends capturing) is not active yet (pytest_load_initial_conftests).
This will result in pdb raising
BdbQuitthen "correctly".