Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: limit coveralls version #98

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Nov 4, 2021

Description

Coveralls 3.3 is failing on github actions across platforms. Limiting install to see if something in the new version is at fault.

https://github.com/TheKevJames/coveralls-python/releases

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

If this successfully runs on Github Actions, it works.

Test Configuration

Github Actions

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing
Copy link
Member Author

jklenzing commented Nov 4, 2021

Note: same error seen in the Github Actions logs documented here: TheKevJames/coveralls-python#333

@jklenzing jklenzing marked this pull request as ready for review November 4, 2021 16:23
@jklenzing
Copy link
Member Author

This solves the problem for the time being. Looking through the logs, the broken version use coveralls 3.3 and coverage 6.1.1. The last working version uses coveralls 3.2 and coverage 5.5 (as does this branch). Looking through the issues at both packages, the problem seems to be on the coverage side, but this is not something we currently control in test_requirements. We could add it and put the limit there in theory.

@jklenzing
Copy link
Member Author

Leaving changelog blank until we decide which package gets the limit.

@jklenzing
Copy link
Member Author

jklenzing commented Nov 4, 2021

Pinging all the core developers for thoughts via review.

Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this solution across packages.

Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with this solution across packages.

@jklenzing jklenzing merged commit f57912e into omni_quickfix_meta Nov 4, 2021
@jklenzing jklenzing deleted the jklenzing-patch-1 branch November 4, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants