Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test Cases #24

Merged
merged 5 commits into from Sep 21, 2023
Merged

Adding Test Cases #24

merged 5 commits into from Sep 21, 2023

Conversation

devendragovil
Copy link
Contributor

Adding test cases for the neighborhood module.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.85% 🎉

Comparison is base (df312ab) 87.61% compared to head (111fbe6) 90.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   87.61%   90.47%   +2.85%     
==========================================
  Files           7        7              
  Lines         105      105              
==========================================
+ Hits           92       95       +3     
+ Misses         13       10       -3     
Files Changed Coverage Δ
topoembedx/neighborhood.py 75.00% <100.00%> (+25.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devendragovil
Copy link
Contributor Author

@ninamiolane Requesting your review. Docs deployment failed, but I think it has nothing to do with the code changes.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Very important to test this module indeed. I have made one minor, yet very important, comment on the naming of test functions.

Why is the docs deployment failing?

test/test_neighborhood.py Outdated Show resolved Hide resolved
test/test_neighborhood.py Outdated Show resolved Hide resolved
@devendragovil
Copy link
Contributor Author

@ninamiolane Have made the requested changes.

@devendragovil
Copy link
Contributor Author

@ninamiolane
I am trying to resolve the doc deployment problem. One similar issue seems to relate to insufficient permissions with access tokens: JamesIves/github-pages-deploy-action#922

@ninamiolane
Copy link
Collaborator

I see for the docs issue! Hm, let's just try to merge the PR then 🤞

@ninamiolane ninamiolane merged commit ba7a91e into pyt-team:main Sep 21, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants