Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected typos and some clean-ups #42

Merged
merged 1 commit into from
May 7, 2024

Conversation

rodroadl
Copy link
Contributor

@rodroadl rodroadl commented May 6, 2024

corrected typos and did some clean-ups.

p.s one thing I noticed is inconsistent usage of DeepCell. Some are instantiated with dimensions=2 and others with default dimensions which is dimensions=128, thus resulting different output. And, some output in the tutorial does not match the given code.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for catching all these!

@ninamiolane ninamiolane merged commit ebbd42f into pyt-team:main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants