Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: Manually create pylint cache directory #770

Merged
merged 1 commit into from Sep 23, 2021

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented Sep 23, 2021

Motivation and Context

Pylint version 2.10 has a bug when trying to create its cache directory: pylint-dev/pylint#4900. This causes an error message to be displayed to students, which is confusing.

Your Changes

Description: While this was fixed in Pylint version 2.11, we're currently pinned to Pylint 2.10, so I backported the fix directly into our code for now. (It will be removed at the next major release of PythonTA.)

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Verified that the pylint cache directory gets created, even when its parent directory doesn't exist.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@david-yz-liu david-yz-liu merged commit 40d0dfa into pyta-uoft:master Sep 23, 2021
@david-yz-liu david-yz-liu deleted the pylint-cache-dir-fix branch September 23, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant