Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transfer_markers #105

Merged
merged 3 commits into from Jan 7, 2019
Merged

Remove transfer_markers #105

merged 3 commits into from Jan 7, 2019

Conversation

Tadaboody
Copy link
Contributor

Closes #104
Tests still pass - am I missing anything?

Closes #104
Tests still pass - am I missing anything?
@Tadaboody Tadaboody requested a review from Tinche January 6, 2019 21:17
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is "broken" for pytest versions before the marker fixup which made marker transfer unnecessary

its possible that this detail is not actually tested in detail as it was arcane and broken before the marker fixup

for correctness transfer_markers should be declared as a noop when its missing

im not sure how to correctly test this one

@Tinche
Copy link
Member

Tinche commented Jan 6, 2019

Thanks for this contribution. @RonnyPfannschmidt does the PR look ok?

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okish now, unfortunately a test might need too much gymnastics right now (pytests fault)

@Tinche Tinche merged commit 11f8193 into pytest-dev:master Jan 7, 2019
@Tinche
Copy link
Member

Tinche commented Jan 7, 2019

Thanks! Will cut a release later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants