plugin: Set unused_tcp_port_factory scope to 'session' #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tinche, |
|
Hi all, this looks like a fairly straightforward change. Is there anything I can do to help get this merged? Thanks |
|
Add a CHANGELOG entry and this can go in :) |
romainletendart
force-pushed
the
master
branch
from
5c01e01
to
2262350
Compare
|
@Tinche Done. :) |
|
@romainletendart sweet, please include a link to the PR like previous changes and let's get this merged and released :) |
Factories in pytest usually have a scope greater than 'function' to let one use the same factory within bigger scopes. Let us allow unused_tcp_port_factory to be used throughout the same session scope. This will let other session-scoped factories depend on unused_tcp_port_factory without getting a "ScopeMismatch" error.
romainletendart
force-pushed
the
master
branch
from
2262350
to
919638f
Compare
|
@Tinche Done. :) |
|
Thanks, I will release this in the next couple of days! |
|
Hi @Tinche! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factories in pytest usually have a scope greater than 'function' to allow
one use the same factory within bigger scopes. Let us allow
unused_tcp_port_factory to be used throughout the same session scope.
This will allow other session-scoped factories depend on
unused_tcp_port_factory without getting a "ScopeMismatch" error.